Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add undefined error type for onExit #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add undefined error type for onExit #212

wants to merge 1 commit into from

Conversation

skylarmb
Copy link
Contributor

closes #207

@ekilah
Copy link

ekilah commented Jan 21, 2022

Just happened across the old #207 so figured I'd throw a stamp here, not that you asked for mine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekilah ekilah ekilah approved these changes

@amytang0 amytang0 Awaiting requested review from amytang0

@cgfarmer4 cgfarmer4 Awaiting requested review from cgfarmer4

@davidzhanghp davidzhanghp Awaiting requested review from davidzhanghp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onExit can return an undefined error
2 participants
@skylarmb @ekilah