Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing information if slurp from nonexistent resource #582

Closed
mfikes opened this issue Dec 16, 2017 · 1 comment · Fixed by #890
Closed

Missing information if slurp from nonexistent resource #582

mfikes opened this issue Dec 16, 2017 · 1 comment · Fixed by #890

Comments

@mfikes
Copy link
Member

mfikes commented Dec 16, 2017 

cljs.user=> (require '[planck.core :refer [slurp]] '[planck.io :as io])
nil
cljs.user=> (-> "foo" io/resource slurp)
Can't make a reader from
	ExceptionInfo (cljs/core.cljs:10846:11)
	make-reader (planck/io.cljs:92:19)
	reader (planck/io.cljs:263:7)
	apply-to (cljs/core.cljs:3831:1)
	slurp (planck/core.cljs:339:7)
@mfikes
Copy link
Member Author

mfikes commented Dec 12, 2018

In Clojure the error message is

Cannot open <nil> as a Reader.

pyrmont added a commit to pyrmont/planck that referenced this issue Mar 22, 2019
@pyrmont
Fix error messages in planck.io
25d370c 
Planck includes the `planck.io` namespace as a means of providing
functionality equivalent to `clojure.java.io`. The error messages were
not consistent with JVM Clojure, especially when a function argument was
nil. This commit uses the same error messages as JVM Clojure. It
fixes planck-repl#582.
@pyrmont pyrmont mentioned this issue Mar 22, 2019
Merged
mfikes pushed a commit that referenced this issue Mar 22, 2019
@pyrmont @mfikes
Fix error messages in planck.io (#582) (#890)
6ac7834
mfikes pushed a commit that referenced this issue Mar 22, 2019
@pyrmont @mfikes
Fix error messages in planck.io (#582) (#890)
7b628d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error messages in planck.io (#582) pyrmont/planck
1 participant
@mfikes