Print support for TMS and Vector layers "enabled" in Print.js #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added TMS and Vector as valid printable layers to plugins/Print.js
| @@ -238,7 +238,9 @@ gxp.plugins.Print = Ext.extend(gxp.plugins.Tool, { | |||
| function isPrintable(layer) { | |||
| return layer.getVisibility() === true && ( | |||
| layer instanceof OpenLayers.Layer.WMS || | |||
| layer instanceof OpenLayers.Layer.OSM | |||
| layer instanceof OpenLayers.Layer.OSM || | |||
There was a problem hiding this comment.
Let's support more layer-types here!
|
Thanks for your contribution, but I think this will only make sense when the MF print module in GeoServer is updated, and I know of no such plans unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added TMS and Vector as valid printable layers to plugins/Print.js
at about Line 241:
function isPrintable(layer) {
return layer.getVisibility() === true && (
layer instanceof OpenLayers.Layer.WMS ||
layer instanceof OpenLayers.Layer.OSM ||
layer instanceof OpenLayers.Layer.TMS ||
layer instanceof OpenLayers.Layer.Vector
);
}
Yes, I think those layers should be supported, and I just tried them out with Mapfish-print they work fine!
Geoserver has issues with them because they are not using the latest mapfish-print plugin. It crashes because of this (for TMS):
mapfish/mapfish-print@2cee321