Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add no blocking feature to NAM #7

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

add no blocking feature to NAM #7

wants to merge 8 commits into from

Conversation

luipir
Copy link
Contributor

@luipir luipir commented Apr 5, 2017

No description provided.

@luipir luipir requested a review from elpaso April 5, 2017 09:41
elpaso
elpaso approved these changes Apr 5, 2017
View reviewed changes
Copy link
Contributor

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any test? :)

qgiscommons/networkaccessmanager.py Outdated
Usage 2 (No bloking mode)
-------------------------
::
NOTE! if blocking mode return immediatly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: returns immediately

@luipir
Copy link
Contributor Author

luipir commented Apr 5, 2017

I'll ask top @cmedine time slot to write tests for this class

@luipir
Copy link
Contributor Author

luipir commented Apr 5, 2017

@elpaso I tested this version in the WAB context, please let me know if you need more.

In WAB context the lib is used in sync and async mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpaso elpaso elpaso approved these changes

Assignees

@elpaso elpaso

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luipir @elpaso