-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite checkout function for orders #134
Composite checkout function for orders #134
Conversation
@vermeulendivan It seems that orders that have the "composite" checkbox clicked do not get submitted even though the order dialog says that they were submitted. Kazam__00007.webm |
@john-dupuy @Samweli Thanks for the feedback. This is the same what happened to me when using any of the Planet accounts we have. Clipping does the same. The problem is a result of a permission issue (not all accounts are allowed to use clipping or composite), which has been discussed with Asa, Barbara, and Ryan. So not related to the plugin itself. This is also why there are no error on the plugin's side when the request is done, because its the API/server blocking the order because of permission issues with the account. |
Thanks for the explanation @vermeulendivan - looks like it's working with my planet account. Curious if you want to do the error / notification handling in this PR or in a follow-up? |
I noticed the |
@john-dupuy Did respond on Slack, but thought I will get to you here as well. An update has been added to take into account the composite.tif file name, which worked fine for Asa and me. I'm assuming the issue you are getting are also a result of the manifest file which differs (for composite data the annotations are empty!). Can you maybe send me the manifest file(s) for the downloaded data causing the issue on Slack? It will help a lot as I cannot place orders via the plugin because of the permission issue. On the error message, I had a quick look and your suggestion on how to show the error message should work great. I will add it for clipping as well, as the same problem happens when clipping is enabled. Its strange that this has not been added to the plugin for clipping, and the plugin will actually show that the order went through with no issue even though clipping is not allowed. |
f449bb1
to
d9d78d8
Compare
@john-dupuy @Samweli Following improvements has been implemented:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested both the error message and the "Add to map" button and they are working as expected. Thanks for the fixes @vermeulendivan!
Fixes #131
Adds an option for the user when applying for an order to composite the satellite data. This is based on how it looks in ArcMap (example received).
Composite option:
![image](https://private-user-images.githubusercontent.com/79740955/252974488-7a808c24-3ea1-40dd-8d22-917da6141a35.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDM1ODQsIm5iZiI6MTczOTY0MzI4NCwicGF0aCI6Ii83OTc0MDk1NS8yNTI5NzQ0ODgtN2E4MDhjMjQtM2VhMS00MGRkLThkMjItOTE3ZGE2MTQxYTM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE4MTQ0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcyNDg0ODBmYmY2NDQ2MGJiNzg2ZTdmOTI3NTczYjUyYTc1NTU1NDQ3ZDlkMGJhNDQ2NzFkM2JkMDFmNWQzY2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.faMuMcTT4HRiWr8lVOr3sHHHjfJoPELD4w7uEs69x24)
Composite raster added to canvas using the Add to map button:
![image](https://private-user-images.githubusercontent.com/79740955/252974683-22802ba1-378c-4bf3-93bc-6e1082d03af1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDM1ODQsIm5iZiI6MTczOTY0MzI4NCwicGF0aCI6Ii83OTc0MDk1NS8yNTI5NzQ2ODMtMjI4MDJiYTEtMzc4Yy00YmYzLTkzYmMtNmUxMDgyZDAzYWYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE4MTQ0NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRkMmVjMDU3OWU4MDcwNzdhYTZmYTNmOTQ2YjBlM2M5Y2EyZDQ0MTc5NzUxMGJjZTgyN2MzZTY1NGEyM2M0ZjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.2L0nL5U-JnwJUOhHC5QgEhmZcGeupOzhm9glwPCU7ZI)