Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite checkout function for orders #134

Merged
merged 6 commits into from
Jul 19, 2023

Conversation

vermeulendivan
Copy link
Collaborator

@vermeulendivan vermeulendivan commented Jul 12, 2023

Fixes #131

Adds an option for the user when applying for an order to composite the satellite data. This is based on how it looks in ArcMap (example received).

  • Composite button on step 3 of the order
  • Adds the composite json to tools if enabled
  • Composite type allowed
  • Manifest file reading had to be updated to accommodate composite cases
  • Processing of the data after the download finished has been updated to accommodate composite rasters

Composite option:
image

Composite raster added to canvas using the Add to map button:
image

@vermeulendivan vermeulendivan added the enhancement New feature or request label Jul 12, 2023
@vermeulendivan vermeulendivan requested a review from Samweli July 12, 2023 12:44
@john-dupuy
Copy link
Contributor

john-dupuy commented Jul 14, 2023

@vermeulendivan It seems that orders that have the "composite" checkbox clicked do not get submitted even though the order dialog says that they were submitted.

Kazam__00007.webm

@vermeulendivan
Copy link
Collaborator Author

@john-dupuy @Samweli Thanks for the feedback. This is the same what happened to me when using any of the Planet accounts we have. Clipping does the same. The problem is a result of a permission issue (not all accounts are allowed to use clipping or composite), which has been discussed with Asa, Barbara, and Ryan. So not related to the plugin itself. This is also why there are no error on the plugin's side when the request is done, because its the API/server blocking the order because of permission issues with the account.
Asa tested this with his account and it works perfect. There is a long discussion on Slack about this, I linked the discussion in Slack for you to have a look at.

@john-dupuy
Copy link
Contributor

Thanks for the explanation @vermeulendivan - looks like it's working with my planet account. Curious if you want to do the error / notification handling in this PR or in a follow-up?

@john-dupuy
Copy link
Contributor

I noticed the Add to Map button does not work for composited orders, I expect because the tif file has a different name? composite.tif

@vermeulendivan
Copy link
Collaborator Author

@john-dupuy Did respond on Slack, but thought I will get to you here as well.

An update has been added to take into account the composite.tif file name, which worked fine for Asa and me. I'm assuming the issue you are getting are also a result of the manifest file which differs (for composite data the annotations are empty!). Can you maybe send me the manifest file(s) for the downloaded data causing the issue on Slack? It will help a lot as I cannot place orders via the plugin because of the permission issue.

On the error message, I had a quick look and your suggestion on how to show the error message should work great. I will add it for clipping as well, as the same problem happens when clipping is enabled. Its strange that this has not been added to the plugin for clipping, and the plugin will actually show that the order went through with no issue even though clipping is not allowed.

@vermeulendivan vermeulendivan force-pushed the dev_composite_checkout branch from f449bb1 to d9d78d8 Compare July 19, 2023 11:59
@vermeulendivan
Copy link
Collaborator Author

@john-dupuy @Samweli Following improvements has been implemented:

  • If an account does not have permission to make use of the Composite or Clipping tools, an error message will display
  • This update should also take into account other request failures
  • Adding Composite data using the Add to map button will work now for cases contained in folders
  • Had a look at the NITF format, and this also required a fix
  • Did tests using data downloaded via Explorer by copy and pasting the data into another folder as this is the only way I can do it atm (cannot download composite/clipping data from within the plugin)

Error message for Composite:
image

Error message for clipping:
image

Copy link
Contributor

@john-dupuy john-dupuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested both the error message and the "Add to map" button and they are working as expected. Thanks for the fixes @vermeulendivan!

@john-dupuy john-dupuy merged commit 665b220 into planetlabs:master Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite order option
2 participants