every node needs a key pair #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keystore or trustwallet) * renamed GetValidatorAddress to GetNodeAddress * fixed lib/test/e2e failing test case. The issue is an internal race condition of the unit test network in case of 1 node. Moving to two nodes solves the issue with the test case. In case of 1 validator, the first chain interaction happens before the address environment variablesare set. Signed-off-by: Jürgen Eckel <juergen@riddleandcode.com>
Signed-off-by: Jürgen Eckel <juergen@riddleandcode.com>
Signed-off-by: Jürgen Eckel <juergen@riddleandcode.com>
jmastr
requested changes
Nov 26, 2024
Signed-off-by: Jürgen Eckel <juergen@riddleandcode.com>
jmastr
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted for a panic as the binary can also be used to manage keyrings, and it might be used when there is not yet a keyring available.