internal/update: don't error with no build version

Signed-off-by: Matt Layher <mdlayher@planetscale.com>
planetscale · Dec 22, 2023 · 96492a1 · 96492a1
1 parent 90e87e0
commit 96492a1
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/internal/cmd/root.go b/internal/cmd/root.go
@@ -100,7 +100,7 @@ func Execute(ctx context.Context, ver, commit, buildDate string) int {
 			case ui := <-updateCheckRes:
 				ui.PrintUpdateHint(ver)
 			case err := <-updateCheckErr:
-				fmt.Fprintf(os.Stderr, "Updater error: %#v\n", err)
+				fmt.Fprintf(os.Stderr, "Updater error: %v\n", err)
 			case <-updateTimeout:
 			}
 		}()

diff --git a/internal/update/update.go b/internal/update/update.go
@@ -121,6 +121,16 @@ func checkVersion(
 
 	v2, err := version.NewVersion(buildVersion)
 	if err != nil {
+		if buildVersion == "" {
+			// A self-compiled binary has no version and thus parsing the
+			// version fails.
+			return &UpdateInfo{
+				Update:      false,
+				Reason:      fmt.Sprintf("Binary has no build version, cannot compare against latest version (%s)", info.Version),
+				ReleaseInfo: info,
+			}, nil
+		}
+
 		return nil, err
 	}
 

diff --git a/internal/update/update_test.go b/internal/update/update_test.go
@@ -64,6 +64,12 @@ func TestCheckVersion(t *testing.T) {
 		update        bool
 		lastChecked   time.Time
 	}{
+		{
+			name:          "self-compiled",
+			buildVersion:  "",
+			latestVersion: "v0.2.0",
+			update:        false,
+		},
 		{
 			name:          "new version",
 			buildVersion:  "v0.1.0",
@@ -112,6 +118,10 @@ func TestCheckVersion(t *testing.T) {
 
 			c.Assert(err, qt.IsNil)
 			c.Assert(updateInfo.Update, qt.Equals, tt.update, qt.Commentf("reason: %s", updateInfo.Reason))
+
+			if !tt.update {
+				t.Logf("reason: %s", updateInfo.Reason)
+			}
 		})
 	}
 }