-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: bump planetscale-go to v0.15.0 #145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
added a commit
that referenced
this pull request
Apr 6, 2021
This PR uses the newly added `*planetscale.Error` and its various new error codes (see: planetscale/planetscale-go#38). The following improvement was made: * We introduced a new helper function, called `cmdutil.ErrCode()` that returns the `planetscale.ErrorCode` if the error type is `*planetscale.Error`. This is handy function that let us type switch on the `planetscale.ErrorCode` type. * We introduced a new `cmdutil.MalformedError` function that returns a human readable error message if the API returns any response that is not JSON. This is usually and indication the API is down and we receive 5xx HTML content from the LB or other intermediate proxies. * I went over all Client calls made to the API and we now fully cover every single call. We make sure to handle for `ErrNotFound` errors also to handle `ErrResponseMalformed` responses. depends on: #145 closes: planetscale/surfaces#148
iheanyi
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
fatih
added a commit
that referenced
this pull request
Apr 6, 2021
This PR uses the newly added `*planetscale.Error` and its various new error codes (see: planetscale/planetscale-go#38). The following improvement was made: * We introduced a new helper function, called `cmdutil.ErrCode()` that returns the `planetscale.ErrorCode` if the error type is `*planetscale.Error`. This is handy function that let us type switch on the `planetscale.ErrorCode` type. * We introduced a new `cmdutil.MalformedError` function that returns a human readable error message if the API returns any response that is not JSON. This is usually and indication the API is down and we receive 5xx HTML content from the LB or other intermediate proxies. * I went over all Client calls made to the API and we now fully cover every single call. We make sure to handle for `ErrNotFound` errors also to handle `ErrResponseMalformed` responses. depends on: #145 closes: planetscale/surfaces#148
asbiaidw5
added a commit
to asbiaidw5/cli
that referenced
this pull request
Aug 6, 2024
This PR uses the newly added `*planetscale.Error` and its various new error codes (see: planetscale/planetscale-go#38). The following improvement was made: * We introduced a new helper function, called `cmdutil.ErrCode()` that returns the `planetscale.ErrorCode` if the error type is `*planetscale.Error`. This is handy function that let us type switch on the `planetscale.ErrorCode` type. * We introduced a new `cmdutil.MalformedError` function that returns a human readable error message if the API returns any response that is not JSON. This is usually and indication the API is down and we receive 5xx HTML content from the LB or other intermediate proxies. * I went over all Client calls made to the API and we now fully cover every single call. We make sure to handle for `ErrNotFound` errors also to handle `ErrResponseMalformed` responses. depends on: planetscale/cli#145 closes: planetscale/surfaces#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: planetscale/planetscale-go#39 (please approve that first so I can update this PR)