Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: bump planetscale-go to v0.15.0 #145

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

fatih
Copy link
Member

@fatih fatih commented Apr 6, 2021

Requires: planetscale/planetscale-go#39 (please approve that first so I can update this PR)

@fatih fatih requested a review from a team as a code owner April 6, 2021 06:14
fatih added a commit that referenced this pull request Apr 6, 2021
This PR uses the newly added `*planetscale.Error` and its various new
error codes (see:
planetscale/planetscale-go#38). The following
improvement was made:

* We introduced a new helper function, called `cmdutil.ErrCode()` that
  returns the `planetscale.ErrorCode` if the error type is
  `*planetscale.Error`. This is handy function that let us type switch
  on the `planetscale.ErrorCode` type.
* We introduced a new `cmdutil.MalformedError` function that returns a
  human readable error message if the API returns any response that is
  not JSON. This is usually and indication the API is down and we
  receive 5xx HTML content from the LB or other intermediate proxies.
* I went over all Client calls made to the API and we now fully cover
  every single call. We make sure to handle for `ErrNotFound` errors
  also to handle `ErrResponseMalformed` responses.

depends on: #145

closes: planetscale/surfaces#148
Copy link
Member

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fatih fatih merged commit c680b9d into main Apr 6, 2021
@fatih fatih deleted the fatih/update-planetscale-go branch April 6, 2021 13:53
fatih added a commit that referenced this pull request Apr 6, 2021
This PR uses the newly added `*planetscale.Error` and its various new
error codes (see:
planetscale/planetscale-go#38). The following
improvement was made:

* We introduced a new helper function, called `cmdutil.ErrCode()` that
  returns the `planetscale.ErrorCode` if the error type is
  `*planetscale.Error`. This is handy function that let us type switch
  on the `planetscale.ErrorCode` type.
* We introduced a new `cmdutil.MalformedError` function that returns a
  human readable error message if the API returns any response that is
  not JSON. This is usually and indication the API is down and we
  receive 5xx HTML content from the LB or other intermediate proxies.
* I went over all Client calls made to the API and we now fully cover
  every single call. We make sure to handle for `ErrNotFound` errors
  also to handle `ErrResponseMalformed` responses.

depends on: #145

closes: planetscale/surfaces#148
asbiaidw5 added a commit to asbiaidw5/cli that referenced this pull request Aug 6, 2024
This PR uses the newly added `*planetscale.Error` and its various new
error codes (see:
planetscale/planetscale-go#38). The following
improvement was made:

* We introduced a new helper function, called `cmdutil.ErrCode()` that
  returns the `planetscale.ErrorCode` if the error type is
  `*planetscale.Error`. This is handy function that let us type switch
  on the `planetscale.ErrorCode` type.
* We introduced a new `cmdutil.MalformedError` function that returns a
  human readable error message if the API returns any response that is
  not JSON. This is usually and indication the API is down and we
  receive 5xx HTML content from the LB or other intermediate proxies.
* I went over all Client calls made to the API and we now fully cover
  every single call. We make sure to handle for `ErrNotFound` errors
  also to handle `ErrResponseMalformed` responses.

depends on: planetscale/cli#145

closes: planetscale/surfaces#148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants