Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: improve "Error: Not Found" messages #148

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

fatih
Copy link
Member

@fatih fatih commented Apr 6, 2021

This PR improves all generic Error: Not Found messages with more detailed and useful messages. Also in every single message, we also include the organization, to make sure the user didn't accidentally execute the CLI command on a different organization.

depends on: #147

closes: planetscale/project-big-bang#163

@fatih fatih requested a review from a team as a code owner April 6, 2021 09:00
@fatih fatih force-pushed the fatih/better-not-found-errors branch from 9559078 to 4c2f2e5 Compare April 6, 2021 09:50
Copy link
Member

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dope but also LGTM!

This PR improves all generic `Error: Not Found` messages with more
detailed and useful messages. Also in every single message we also
include the organization, to make sure the user didn't accidentaly
executed the CLI command on a different organization.

depends on: #147

closes: planetscale/surfaces#163
@fatih fatih force-pushed the fatih/better-not-found-errors branch from 4c2f2e5 to f724f47 Compare April 6, 2021 14:01
@fatih fatih merged commit 708ed76 into main Apr 6, 2021
@fatih fatih deleted the fatih/better-not-found-errors branch April 6, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants