Standardize on show for displaying resources
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvanw
approved these changes
Apr 6, 2021
fatih
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Looks good to me 👍🏼 I think we should remove the aliases though to avoid any confusion. I think get-access and show-access leading to the same command is not something we would want. I like aliases like 'list, l' or 'deploy-request, dr', because that's natural.
|
@fatih For |
|
@iheanyi for all of them. I think we should be consistent with those commands whenever we can. Adding them is easy, but removing them later will be a lot of harder once people start using them. Cobra makes it really easy to extend them like this 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request standardizes on
showas the primary verb, with aliases togetas well in case some folks expect that.Closes https://github.com/planetscale/project-big-bang/issues/173.