cmd: return a user friendly message if the user is not authenticated #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscoutermarsh
approved these changes
Apr 9, 2021
This PR adds a pre-hook to relevant subcommands that checks if the user is authenticated already. If not, it returns a user friendly error message and tells them to authenticate via `pscale auth login`. Before: ``` $ pscale db list Error: required flag(s) "org" not set ``` After: ``` $ pscale db list Error: not authenticated yet. Please run 'pscale auth login' ``` We didn't add the pre-hook to `rootCmd`, because that would block the user executing the `pscale auth` commands. closes planetscale/surfaces#205
fatih
force-pushed
the
fatih/show-user-friendly-auth-message
branch
from
91ffa41 to
744cc84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-hook to relevant subcommands that checks if the user is authenticated already. If not, it returns a user-friendly error message and tells them to authenticate via
pscale auth login.Before:
After:
We didn't add the pre-hook to
rootCmd, because that would block the user from executing thepscale authcommands.closes https://github.com/planetscale/project-big-bang/issues/205