Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll zap/exp forward again with fix #941

Merged
merged 1 commit into from
Dec 2, 2024
Merged

roll zap/exp forward again with fix #941

merged 1 commit into from
Dec 2, 2024

Conversation

mattrobenolt
Copy link
Member

@mattrobenolt mattrobenolt commented Dec 2, 2024

v0.3.0 introduced a backwards incompatible change in the API. Options used to be a struct you could pass nil to, and turned into variadic arguments, which means we were explicitly passing in nil as an argument.

Refs uber-go/zap#1339

v0.3.0 introduced a backwards incompatible change in the API. Options
used to be a struct you could pass nil to, and turned into variadic
arguments, which means we were explicitly passing in nil as an argument.
@mattrobenolt mattrobenolt requested a review from a team as a code owner December 2, 2024 22:56
@mscoutermarsh mscoutermarsh merged commit b50c743 into main Dec 2, 2024
1 check passed
@mscoutermarsh mscoutermarsh deleted the fix-zap-exp branch December 2, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants