Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support binary text data #167

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Support binary text data #167

merged 1 commit into from
Feb 9, 2024

Conversation

ayrton
Copy link
Contributor

@ayrton ayrton commented Feb 9, 2024

Don't return 8-bit signed integers for binary text data

Fixes #165

mattrobenolt
mattrobenolt approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@mattrobenolt mattrobenolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be correct.

iheanyi
iheanyi approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@iheanyi iheanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@ayrton ayrton merged commit 1a00a50 into main Feb 9, 2024
5 checks passed
@ayrton ayrton deleted the binary-text branch February 9, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iheanyi iheanyi iheanyi approved these changes

@mattrobenolt mattrobenolt mattrobenolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple show tables statement not cast correctly by default
3 participants
@ayrton @mattrobenolt @iheanyi