Automatically split up each batch into an acceptable request to the Stitch API #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Stitch API has a few limitations about the request size and contents :
We do have a
batch-size
CLI parameter in theps-http-tap
that allows the caller to pick a batch size for the request to Stitch API. But this requires a lot of manual trial and error to get the value right.Instead of asking the customer to pick a batch size in the request, we will now automatically detect the size of the request body that we send to Stitch API.
Implemented in :
singer-tap/cmd/internal/batch_writer.go
Lines 107 to 112 in fa8a055