Introduce Durability Policy in VTop #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…upgrade-test Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
…specification instead of cell Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
frouioui
approved these changes
Jul 11, 2022
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
that referenced
this pull request
Jul 28, 2022
* feat: add durability policy as a field in keyspace configuration Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update crds for test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add reconciliation logic for keyspace record in the topo server Signed-off-by: Manan Gupta <manan@planetscale.com> * test: update tests to set the durability policy and verify it in the upgrade-test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove default from durability_policy Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix initial config by moving durability policy to the keyspace specification instead of cell Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: run make generate Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: remove a new line added accidentally Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
added a commit
that referenced
this pull request
Jul 28, 2022
* Introduce Durability Policy in VTop (#282) * feat: add durability policy as a field in keyspace configuration Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update crds for test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add reconciliation logic for keyspace record in the topo server Signed-off-by: Manan Gupta <manan@planetscale.com> * test: update tests to set the durability policy and verify it in the upgrade-test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove default from durability_policy Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix initial config by moving durability policy to the keyspace specification instead of cell Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: run make generate Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: remove a new line added accidentally Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix durability policy check Signed-off-by: Manan Gupta <manan@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the durability policy in the Vitess Operator. Durability Policy is introduced as a configuration in the Keyspace specification.
Furthermore, the reconciliation logic for the same has also been added which ensures that the durability policy configured matches the durability policy in the topo server.
If the durability_policy is left unspecified, then VTop will not set a default or configure it at all. This is required for upgrade considerations. Since the previous version of VTop didn't support this configuration, when VTop is upgraded, it is expected that the durability policy configuration will be empty. If it is, we do not want to presume its value and set a default because that could be different than the durability policy that the user has already set in v14 using SetKeyspaceDurabilityPolicy.
Once VTop is upgraded, the durability policy config can be added and VTop will ensure that it is configured properly henceforth.