[VTAdmin] Change vars from REACT_APP to VITE #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frouioui
approved these changes
Apr 5, 2023
|
Went through the repository and it does not seem like we need to change anything, i'll let @GuptaManan100 confirm though. |
GuptaManan100
approved these changes
Apr 6, 2023
Comment on lines
344
to
349
| 'REACT_APP_VTADMIN_API_ADDRESS': "%s", | ||
| 'REACT_APP_FETCH_CREDENTIALS': "omit", | ||
| 'REACT_APP_ENABLE_EXPERIMENTAL_TABLET_DEBUG_VARS': false, | ||
| 'REACT_APP_BUGSNAG_API_KEY': "", | ||
| 'REACT_APP_DOCUMENT_TITLE': "", | ||
| 'REACT_APP_READONLY_MODE': %s, |
There was a problem hiding this comment.
We should probably keep the old env variables for one release to ensure backward compatibility.
We can drop these after 2.10 release
|
Rebased on |
frouioui
force-pushed
the
frances/update-vtadmin-vite
branch
3 times, most recently
from
7030b42
to
a3a84d4
Compare
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui
force-pushed
the
frances/update-vtadmin-vite
branch
from
a3a84d4
to
e888bcf
Compare
notfelineit
commented
Apr 6, 2023
…vitess-operator into frances/update-vtadmin-vite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With vitessio/vitess#12831, we're migrating VTAdmin from create-react-app to vite. One of the changes is that all
REACT_APP_*vars are changed toVITE_*