Upgrade Kubernetes and controller-runtime dependencies #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
force-pushed
the
upgrade-kubernetes-version
branch
from
efa5caf
to
e9bdc17
Compare
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
dbussink
approved these changes
Jan 3, 2024
frouioui
approved these changes
Jan 3, 2024
|
Looks good to me, thank you @GuptaManan100! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the k8s and the controller-runtime dependencies for the vitess-operator. A lot of build issues occurred on upgrading due to the breaking changes made. Most significantly there were 2 changes -
In version 16 of controller-runtime, configuration of cache filtering has changed - ⚠️ Allow configuring more granular cache filtering kubernetes-sigs/controller-runtime#2421. This meant that the filtering of cache based on the namespaces had to change in the operator.
In version 15 of controller-runtime, context was added to EventHandlers (⚠ Add context to EventHandler(s) kubernetes-sigs/controller-runtime#2139), removal of dependency injection by changing structs to being internal and having functions instead (⚠️ Refactor source/handler/predicate packages to remove dep injection kubernetes-sigs/controller-runtime#2120).
Tests with different versions of kind image -
Related Issues