Address review comments

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
planetscale · Dec 30, 2024 · 40f4302 · 40f4302
1 parent e029da1
commit 40f4302
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 70 deletions.
diff --git a/go/test/endtoend/vreplication/r b/go/test/endtoend/vreplication/r
diff --git a/go/test/endtoend/vreplication/r2 b/go/test/endtoend/vreplication/r2
diff --git a/go/vt/vtgate/vindexes/vschema_routing_test.go b/go/vt/vtgate/vindexes/vschema_routing_test.go
@@ -236,7 +236,7 @@ func TestAutoGlobalRoutingBasic(t *testing.T) {
 		Tables: map[string]*vschemapb.Table{
 			"table5":   {}, // unique, should be added to global routing
 			"scommon1": {}, // common with unsharded1 and unsharded2, should be added to global routing because it's in the vschema
-			"scommon2": {}, // common with unsharded2, ambiguous because of sharded2
+			"scommon2": {}, // common with unsharded2, not ambiguous because sharded2 sets RequireExplicitRouting
 		},
 	}
 	sharded2 := &vschemapb.Keyspace{
@@ -250,8 +250,8 @@ func TestAutoGlobalRoutingBasic(t *testing.T) {
 		// none should be considered for choice as global or ambiguous because of RequireExplicitRouting
 		Tables: map[string]*vschemapb.Table{
 			"table6":   {}, // unique
-			"scommon2": {}, // common with sharded2, but has RequireExplicitRouting
-			"scommon3": {}, // common with sharded2
+			"scommon2": {}, // common with sharded1, but has RequireExplicitRouting
+			"scommon3": {}, // unique
 		},
 	}
 	for _, ks := range []*vschemapb.Keyspace{sharded1, sharded2} {