Remove TableSectionViewModel.collapsed, close #120 #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is seems to be a vestigial aspect of the framework from early PlanGrid days. We don't use this anywhere in PlanGrid. To achieve this sort of "collapsing" behavior, you'd capture this state elsewhere in your model, and simply regenerate your SectionModel with zero CellViewModels. This is how we currently do this in PlanGrid. And, I think this makes more sense to generate full state changes, rather than "hiding" a section. (i.e., this is sort of a hack) Further, this is complicates notions of "empty/nil state" (see #48 and IP-3275) and I want to remove that complexity. Closes #120
jessesquires
force-pushed
the
jsq/fix-#120
branch
from
57121f6
to
691206b
Compare
ghost
assigned 
|
LOL Thanks Hera. 👩🚀 |
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is seems to be a vestigial aspect of the framework from early PlanGrid days.
We don't use this anywhere in PlanGrid.
To achieve this sort of "collapsing" behavior, you'd capture this state elsewhere in your model, and simply regenerate your SectionModel with zero CellViewModels.
This is how we currently do this in PlanGrid.
And, I think this makes more sense to generate full state changes, rather than "hiding" a section. (i.e., this is sort of a hack)
Further, this is complicates notions of "empty/nil state" (see #48 and IP-3275) and I want to remove that complexity.
Closes #120