Fix crash when diffing to/from empty/nil states to/from non-empty/nil states #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jessesquires
force-pushed
the
jsq/fix-empty-state-crash
branch
from
eaa5438 to
d552263
Compare
|
Ok. Pushed more fixes. (Tests were failing) I can consistently crash UIKit because That's out of scope for this PR right now though. We'll have to live with it until we can switch to IGListKit. |
|
@jessesquires Is the crashing consistent enough that we could throw an exception from |
jessesquires
force-pushed
the
jsq/fix-empty-state-crash
branch
from
d552263 to
b7f8be1
Compare
… states Closes #124 Internal: IP-3275
jessesquires
force-pushed
the
jsq/fix-empty-state-crash
branch
from
b7f8be1 to
826784d
Compare
|
Follow-up at #126 |
1 similar comment
|
Follow-up at #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
Internal: IP-3275