Add Collection conformance for *SectionModel types #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benasher44
force-pushed
the
basher/add-collection-conformance
branch
from
370bd84 to
ed3f40c
Compare
benasher44
changed the title
asmallteapot
previously approved these changes
Aug 21, 2018
benasher44
dismissed stale reviews from jessesquires and asmallteapot
via
25a55de
jessesquires
previously approved these changes
Aug 27, 2018
Sources/CollectionViewModel.swift
Outdated
| return self.cellViewModels.startIndex | ||
| } | ||
|
|
||
| public var endIndex: Int { |
There was a problem hiding this comment.
actually, each of these declarations should have /// :nodoc: to exempt them from generating empty docs
Sources/CollectionViewModel.swift
Outdated
| @@ -167,3 +167,22 @@ public struct CollectionSectionViewModel: DiffableViewModel { | |||
| self.diffingKey = diffingKey | |||
| } | |||
| } | |||
|
|
|||
| /// Collection support for diffing | |||
| extension CollectionSectionViewModel: Collection { | |||
There was a problem hiding this comment.
nit: maybe say "CollectionSectionViewModel conforms to Collection"
or leave as /// :nodoc:
There was a problem hiding this comment.
Why is CollectionSectionViewModel conforms to Collection more informative than CollectionSectionViewModel: Collection + the current comment?
There was a problem hiding this comment.
Sorry just feel like that comment is a bit redundant. Just in case, I add backticks around Collection, which might make it read a bit better.
benasher44
force-pushed
the
basher/add-collection-conformance
branch
from
d01b430 to
535d58c
Compare
benasher44
force-pushed
the
basher/add-collection-conformance
branch
from
e69beed to
404dbc3
Compare
jessesquires
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This adds
Collectionconformance to *SectionModeltypes, which eases upgrading to Swift-based, non-Dwifft diffing (most diffCollections).Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.