Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ReactiveLists for Swift 4.2; drop iOS 9 support #144

Merged
merged 6 commits into from
Sep 20, 2018
Merged

Upgrade ReactiveLists for Swift 4.2; drop iOS 9 support #144

merged 6 commits into from
Sep 20, 2018

Conversation

benasher44
Copy link
Contributor

@benasher44 benasher44 commented Sep 20, 2018 •
edited
Loading

Changes in this pull request

This upgrades ReactiveLists for Swift 4.2 (fixes #141).

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

@benasher44 benasher44 added this to the 0.3.0 milestone Sep 20, 2018
@PlanBot-iOS
Copy link

PlanBot-iOS commented Sep 20, 2018 •
edited
Loading

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@benasher44 benasher44 changed the title Upgrade ReactiveLists for Swift 4.2 Upgrade ReactiveLists for Swift 4.2; drop iOS 9 support Sep 20, 2018
jessesquires
jessesquires approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯

@benasher44 benasher44 merged commit d4dc7ab into master Sep 20, 2018
@benasher44 benasher44 deleted the basher/swift42 branch September 20, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesquires jessesquires jessesquires approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

Drop iOS 9 and migrate to Swift 4.2
3 participants
@benasher44 @PlanBot-iOS @jessesquires