Add support for UISwipeActionsConfiguration #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jessesquires
suggested changes
Jun 26, 2019
|
Great! Will do.
…On Wed, Jun 26, 2019 at 11:18 AM Jesse Squires ***@***.***> wrote:
***@***.**** requested changes on this pull request.
We've already dropped support for iOS 10, so I'd say we just convert over
to the new API and remove the availables
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#167?email_source=notifications&email_token=AAYXDASIYHHMQ4ALQFDJR6LP4OXHNA5CNFSM4H3NKT52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4X44RA#pullrequestreview-254791236>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAYXDATEHLZQNCEIQPDHRHDP4OXHNANCNFSM4H3NKT5Q>
.
|
|
I also need to add default implementations so that these props are all Optional! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This adds tableview support for the
UISwipeActionsConfigurationAPI, which was introduced in iOS 11. This should be used to replace usage of theUITableViewRowActionAPI, which will be deprecated in iOS 13.Issue fixed: none
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.