SP-3760 Guard against infinite loop page trees #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guard against infinite loops in the page tree.
I've not been able to find any PDFs with deeper nesting than 10 but someone in pdfrw issues mentioned that a particular tool was creating a subtree for each page so depth would be equal to the number of pages. This seems to be rare though and I've set the max depth to 50000 so I think it should be unlikely to run into this threshold.
Another solution would be to keep track of all
Pages
objects that have been seen already (this is what poppler does) which means we could instantly detect cycles. This would be relatively easy if we could tell the object number but I don't think it's possible withpdfrw
.Testing: