Improve party organization with auto-party #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google testing framework added. Tests refactored
Travis config added
Simple reproduction of the bug:
LRUCache<string, string> lruCache(3);
lruCache.put("key1", "val1");
lruCache.put("key2", "val2");
lruCache.put("key3", "val3");
lruCache.put("key1", lruCache.get("key1"));
The get returns a ref to the value of "key1", the put gets the ref and
invalidate it when it finds "key1" already exists in the cache.
Fix use after free
Similar name of cache instance and cache namespace in tests caused the error: redeclared as different kind of symbol.
Fix redeclared as different kind of symbol issue
Fix wrong namespace name in comment
…en possible, bypassing the call to evaluate. * The item name cache uses the unmodified item name in addition to the modified one. This allows for detecting changes in the unmodified item name. This is used to trigger updates to the modified item name. * PrintText will now truncate the string instead of crashing when it's too long.
…ent multiple parties forming when joining games.
youbetterdont
changed the title
youbetterdont
changed the title
…there was a memory leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When joining a game, players try to form parties as before. That is they freely send invites and accept them. After all players are in a party, we then check that all players are in the same party. If they aren't, the players with the higher wPartyId will leave and then join the party with the lowest wPartyId. Thus, the earliest party formed has priority.
This PR includes #40. I chose to do it this way since this version has already been released as 1.9.8alpha3.
Edit:
Now updated to 1.9.8alpha5. Includes bug fixes to my autoparty changes. Also includes a memory leak fix (item rules and conditions not deleted when uninitialized).