-
-
Notifications
You must be signed in to change notification settings - Fork 12
Separate ProgressBarWithHints into 2 separate widgets #79
Comments
@blazern so if i understand correct the progressbar won't show the progress anymore? |
Why not? I think it should keep the progress logic it has right now. |
@blazern no I agree we should show the progress. So if I understand correctly now, we show a incrementing progressbar, but the colors are gradient. So the closer to finished loading the darker to the end. |
Oh you're right, I somehow totally missed that we show specific progresses and it doesn't fit |
@cyclomaticcomplexity1981, I talked to Olga - she and Sewa think we should try the hints + infinite progress bar from the design (with how What do you think? |
@blazern i am still not sure what you mean, infinite, meaning it doesn't show the progress anymore? Like it used to be? i think i liked to progress better. But we can try and see if the hints are enough. |
Yes, I mean it wouldn't show progress anymore... Maybe it's a good idea to split the current progress-bar-with-hints into 2 separate classes, but to use only the new hints-class, and to leave the extracted progress-bar not used for now. And then to use This way it would be easy to roll back to an not-infinite progressbar in case we would want that. |
@blazern i am confused now, i think the design changed to show progress... So as a first implementation just show the incrementing progressbar at the bottom. |
You're right it did change... |
Separate ProgressBarWithHints into 2 separate widgets #79
Hints should be at the top:
Progress bar should be at the bottom:
Figma: https://www.figma.com/file/lHqzwSaWfsBiWNj9iyOaoh/plante-UI?node-id=2194%3A42214
Because now they're separated, they should be in 2 separate widget with similar logic. E.g. the hints widget can be named
TimedHints
.We should try to reuse the
GradientSpinner
as a progress bar widget. To reuse it, make it so that it would accept customcolors
andborderRadius
in its constructor.If it's not possible, a new widget should be created with a logic similar to
GradientSpinner
.The new progress bar widget should be at the bottom of the page.
TimedHints
should be just below the search bar (findColumn
which contains the search bar inMapPage
).New design should not be applied yet.
The text was updated successfully, but these errors were encountered: