Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several tests #98

Merged
merged 1 commit into from
Mar 11, 2023
Merged

Conversation

Semigradsky
Copy link
Contributor

No description provided.

@Semigradsky
Copy link
Contributor Author

It looks like the shallowEqual property from test suites is not used.

@planttheidea
Copy link
Owner

planttheidea commented Mar 6, 2023

I can kind of glean the goal of this PR from the changes, but just to confirm ... certain specific failures in other libraries were not tested here, and you are adding coverage for those tests? It would be very helpful if a description were added to give context for the change.

It looks like the shallowEqual property from test suites is not used.

It is a little opaque, but it is used when iterating over the entire suite and comparing. The renaming doesn't help there, but was done because it has the same name as a method. Perhaps property access is better.

@Semigradsky
Copy link
Contributor Author

Yeah, Object.create(null) is a pretty old feature (modern equivalent to { __proto__: null }) and I was surprised that some libraries can't handle this. I added a test to avoid issues here.

About sparse arrays - I think it is not a very commonly used feature, I just added a test to represent how it works.

@planttheidea planttheidea merged commit eb76f52 into planttheidea:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants