Handle NULL return value from dlopen #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
suggested changes
Jun 26, 2024
There was a problem hiding this comment.
Hi @EbsHirani, thanks for this PR! The fix itself looks good, but I'd prefer you remove the new flag to coz.
| @@ -185,6 +188,10 @@ _run_parser.add_argument('--fixed-speedup', | |||
| type=int, choices=list(range(0, 101)), default=None, | |||
| help='Evaluate optimizations of a specific amount') | |||
|
|
|||
| _run_parser.add_argument('--debug-libraries', | |||
There was a problem hiding this comment.
I'm not sure I see a point to adding a flag for this when users can just use LD_DEBUG=libs directly when running coz. Can you remove the changes to this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #229