Plasma3 d #31
Plasma3 d #31
Conversation
…sing functions as standalone outside of class
…anch), but also centers[use] needed same fix
…a3Dmask was not correctly initialized for 2D runs. Reading input file operations have now moved before the main PFC loop.
…Q loading and traces; jan2024 update; but no FEM yet
…OT in container still compiled with M3D-C1 support set to False
… M3D-C1 files, so no perturbation
…lass; it's default value is set to False. toolsClass no longer overwrites already existing class variables with None at initialization, hence allowing to set defaults.
|
nice. merging main into plasma3D was a good idea to fix the issues we saw |
…ers for large files who will live in the docker container only.
|
@wingena this looks pretty good! I added a few minor comments throughout the code that should be addressed before we merge the branch into main. Generally they are just CI and workflow related comments. Also, note that I added plasma3D to be the target for CI in this commit: 3373d46 . This means that when you push your code up to github it will automatically trigger the integration tests (only for NSTXU currently until I rebuild docker container with M3DC1 files for D3D as we discussed). You can see the status of the tests here on the PR page, or here. Be sure to "pull" the plasma3D branch down to your machine to get my updates before you go through and edit things. Once you are done resolving each comment, mark it as resolved. When you are ready for me to review again, write a comment here or ping me via email and I will do the final merge into main. |
|
@plasmapotential I resolved the comments you made. The push triggered the test and passed. |
Latest updates to plasma3D