Skip to content

Commit

Permalink
reload translated result in original webview when long pressing close…
Browse files Browse the repository at this point in the history
… button
  • Loading branch information
plateaukao committed Sep 20, 2021
1 parent 75bb651 commit a418d0d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,7 @@ open class BrowserActivity : AppCompatActivity(), BrowserController, OnClickList
binding.twoPanelLayout,
{ showTranslation() },
{ if (ninjaWebView.isReaderModeOn) ninjaWebView.toggleReaderMode() },
{ url -> ninjaWebView.loadUrl(url)},
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class TranslationViewController(
private val twoPaneLayout: TwoPaneLayout,
private val showTranslationAction: () -> Unit,
private val onTranslationClosed: () -> Unit,
private val loadTranslationUrl: (String) -> Unit
) {
private val config: ConfigManager by lazy { ConfigManager(activity) }
private val webView: NinjaWebView by lazy {
Expand Down Expand Up @@ -63,7 +64,11 @@ class TranslationViewController(
translationViewBinding.translationFontMinus.setOnClickListener { decreaseFontSize() }

translationViewBinding.translationClose.setOnClickListener { toggleTranslationWindow(false, onTranslationClosed) }
translationViewBinding.translationClose.setOnLongClickListener{ hideControlButtons(); true }
translationViewBinding.translationClose.setOnLongClickListener{
webView.url?.let { loadTranslationUrl(it) }
toggleTranslationWindow(false)
true
}

translationViewBinding.translationOrientation.setOnClickListener {
val orientation = if (twoPaneLayout.getOrientation() == Orientation.Vertical) Orientation.Horizontal else Orientation.Vertical
Expand Down Expand Up @@ -356,7 +361,7 @@ class TranslationViewController(

private fun toggleTranslationWindow(
isEnabled: Boolean,
onTranslationClosed: () -> Unit
onTranslationClosed: () -> Unit = {}
) {
if (config.translationMode == TranslationMode.ONYX) {
ViewUnit.toggleMultiWindow(activity, isEnabled)
Expand Down

0 comments on commit a418d0d

Please sign in to comment.