Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed trivy vulnerabilities. Update go modules, golang to 1.23 #28

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

deepak07dbz
Copy link

@deepak07dbz deepak07dbz commented Oct 28, 2024

Changed repo target from docker to quay and upgraded golang version to 1.23 as mentioned in trivy vulnerabilities.

$ k get po -A | grep whereabouts
luigi-system whereabouts-lxm9z 1/1 Running 0 46m

$ k describe -n luigi-system po/whereabouts-lxm9z | grep -i image
Image: quay.io/platform9/whereabouts:v0.6-pmk-3427514
Image ID: quay.ioplatform9whereabouts@sha256:2b0de78f3b9f6b43ca0e62afbb3b4b0050358bf7631b06bd4c4acf52d805820a
Normal Pulling 45m kubelet Pulling image "quay.io/platform9/whereabouts:v0.6-pmk-3427514"
Normal Pulled 45m kubelet Successfully pulled image "quay.io/platform9/whereabouts:v0.6-pmk-3427514" in 5.931958779s (5.931966272s including waiting)

cruizen and others added 3 commits October 30, 2024 12:05
Update golang version to `1.23` and use the `toolchain` directive in go.mod
@cruizen
Copy link

cruizen commented Oct 30, 2024

@deepak07dbz The tests from github actions were failing. Made some changes to also run hack/update-codegen.sh

Dockerfile Outdated Show resolved Hide resolved
@cruizen cruizen changed the title fixed trivy vulns Fixed trivy vulnerabilities. Update go modules, golang to 1.23 Oct 30, 2024
@cruizen
Copy link

cruizen commented Oct 30, 2024

@deepak07dbz Please add the path to image generated on quay.io and run trivy image against this image tag.

Also. update the image version in airctl in https://github.com/platform9/airctl/blob/atherton/conf/pmk_cluster_img_list.json with a follow-up PR

@cruizen
Copy link

cruizen commented Nov 18, 2024

Please go ahead and squash and merge. Make a separate PR in airctl 5.11 branch to update the list of images. Raise a pull request with similar testing notes.

@deepak07dbz deepak07dbz merged commit b895e9d into v0.6.4-release Nov 18, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants