Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade execa back to 8.x #58

Open
marcopiraccini opened this issue Dec 4, 2023 · 2 comments · May be fixed by #872
Open

Upgrade execa back to 8.x #58

marcopiraccini opened this issue Dec 4, 2023 · 2 comments · May be fixed by #872
Assignees

Comments

@marcopiraccini
Copy link
Contributor

We had to go back to execa 5.
The reason is that from 6 only ESM is supported in execa, BUT exlectron compiles to JS with CommonJS (actually transforming the import in require`. This would nt be an issue if we use dynamic imprt (like we did) BUT the dynamic import in electron is broken (see: electron/electron#38957) and will be fixed with electron 0.29.

So when electron 0.29 will be available, upgrade execa (and use dymaic import to lad it)

@mcollina
Copy link
Member

mcollina commented Dec 4, 2023

You can also avoid execa entirely and just use child_process.

@marcopiraccini marcopiraccini self-assigned this Feb 13, 2024
@marcopiraccini
Copy link
Contributor Author

Actually, not solve yet :( alex8088/electron-vite#401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants