Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platformatic 2 support and electron 30 [DON'T MERGE] #872

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

marcopiraccini
Copy link
Contributor

@marcopiraccini marcopiraccini commented Sep 30, 2024

Platformatic 2 suppport.
Also fixes: #58 and #742
Generic nodejs applications support is not included here

TODO: add a proper test for the plt2 schemas. See https://github.com/platformatic/meraki/blob/plt2/src/main/lib/inspect-app.mjs#L18

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
@marcopiraccini marcopiraccini changed the title PLT2 test [TEST BRANCH] [CON'T MERGE] PLT2 test [TEST BRANCH] [DON'T MERGE] Sep 30, 2024
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
@marcopiraccini marcopiraccini changed the title PLT2 test [TEST BRANCH] [DON'T MERGE] [DON'T MERGE] Oct 4, 2024
@marcopiraccini marcopiraccini changed the title [DON'T MERGE] Platformatic 2 support [DON'T MERGE] Oct 4, 2024
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
@marcopiraccini marcopiraccini changed the title Platformatic 2 support [DON'T MERGE] Platformatic 2 support and electron 30 [DON'T MERGE] Oct 4, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade execa back to 8.x
2 participants