Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop organizations #809

Merged
merged 2 commits into from
Jul 19, 2024
Merged

feat: drop organizations #809

merged 2 commits into from
Jul 19, 2024

Conversation

ivan-tymoshenko
Copy link
Member

No description provided.

@@ -26,47 +26,5 @@
"author": "Platformatic",
"homepage": "https://example.com",
"public": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we still have this mock @ivan-tymoshenko @tonysnowboardunderthebridge ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the "public" property or the mock whole mock file?

@marcopiraccini
Copy link
Contributor

@ivan-tymoshenko I don't understand, why are we removing the API key here for the calls? If we do that we cannot see the private stackables anymore, right?

@ivan-tymoshenko
Copy link
Member Author

yes, we are dropping private stackables

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@marcopiraccini marcopiraccini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivan-tymoshenko ivan-tymoshenko merged commit cc1c022 into main Jul 19, 2024
2 checks passed
@ivan-tymoshenko ivan-tymoshenko deleted the drop-organizations branch July 19, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants