feat: add TailFileStream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
requested changes
Mar 12, 2024
index.js
Outdated
Comment on lines
69
to
70
| this.emit('open', this.#fd) | ||
| this.emit('ready') |
There was a problem hiding this comment.
Suggested change
| this.emit('open', this.#fd) | |
| this.emit('ready') | |
| process.nextTick(() => { | |
| this.emit('open', this.#fd) | |
| this.emit('ready') | |
| }) |
mcollina
reviewed
Mar 13, 2024
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
mcollina
reviewed
Mar 13, 2024
test/close.test.js
Outdated
|
|
||
| stream.on('data', () => {}) | ||
| stream.on('end', () => { | ||
| stream.close(done) |
There was a problem hiding this comment.
calling stream.close(done) should not be necessary, it should auto-close on 'end' or 'close'.
There was a problem hiding this comment.
I added this test to test this line behavior:
Line 190 in eeb90ca
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.