Add "stcgal_protocol" field #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld in builder/main.py for using stcgal to upload firmware onto STC MCUs in the right way. If we don't explicitly specify which protocol stcgal will use with flag "-P", we'll get stuck in "Cycling power", because stcgal does not always select the correct protocol by autodetection.
|
Thanks! |
ivankravets
added a commit
that referenced
this pull request
Jan 23, 2019
…this field in builder/main.py for using stcgal to upload firmware onto STC MCUs in the right way. If we don't explicitly specify which protocol stcgal will use with flag "-P", we'll get stuck in "Cycling power", because stcgal does not always select the correct protocol by autodetection. (#16)" This reverts commit fe2642e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "stcgal_protocol" field in boards/stcxxxxxx.json and use this field in builder/main.py for using stcgal to upload firmware onto STC MCUs in the right way. If we don't explicitly specify which protocol stcgal will use with flag "-P", we'll get stuck in "Cycling power", because stcgal does not always select the correct protocol by autodetection.
The mapping between protocols and MCU series in stcgal is shown at:
https://github.com/grigorig/stcgal/blob/master/doc/USAGE.md#protocols
Compatibly, users can override default Generic STCxxxxxx stcgal upload_protocol using board_upload.stcgal_protocol option. For example, board_upload.stcgal_protocol = "stc12", board_upload.stcgal_protocol = "stc8", etc.