Fixed an issue when "pio pkg list" and "pio pkg uninstall" commands f…

…ail if there are circular dependencies in the library.json manifests // Resolve #4475

HISTORY.rst

@@ -2,6 +2,7 @@ Release Notes
 =============
 
 .. |PIOCONF| replace:: `"platformio.ini" <https://docs.platformio.org/en/latest/projectconf.html>`__ configuration file
+.. |LIBRARYJSON| replace:: `library.json <https://docs.platformio.org/en/latest/manifests/library-json/index.html>`__
 .. |LDF| replace:: `LDF <https://docs.platformio.org/en/latest/librarymanager/ldf.html>`__
 .. |INTERPOLATION| replace:: `Interpolation of Values <https://docs.platformio.org/en/latest/projectconf/interpolation.html>`__
 .. |UNITTESTING| replace:: `Unit Testing <https://docs.platformio.org/en/latest/advanced/unit-testing/index.html>`__
@@ -23,7 +24,8 @@ PlatformIO Core 6
 * Removed dependency on the "zeroconf" package and install it only when a user lists mDNS devices (issue with zeroconf's LGPL license)
 * Show the real error message instead of "Can not remove temporary directory" when |PIOCONF| is broken (`issue #4480 <https://github.com/platformio/platformio-core/issues/4480>`_)
 * Fixed an issue with an incorrect test summary when a testcase name includes a colon (`issue #4508 <https://github.com/platformio/platformio-core/issues/4508>`_)
-* Fixed an issue when `extends <https://docs.platformio.org/en/latest/projectconf/sections/env/options/advanced/extends.html>`__ does not override options in the right order (`issue #4462 <https://github.com/platformio/platformio-core/issues/4462>`_)
+* Fixed an issue when `extends <https://docs.platformio.org/en/latest/projectconf/sections/env/options/advanced/extends.html>`__ did not override options in the right order (`issue #4462 <https://github.com/platformio/platformio-core/issues/4462>`_)
+* Fixed an issue when `pio pkg list <https://docs.platformio.org/en/latest/core/userguide/pkg/cmd_list.html>`__ and `pio pkg uninstall <https://docs.platformio.org/en/latest/core/userguide/pkg/cmd_uninstall.html>`__ commands fail if there are circular dependencies in the |LIBRARYJSON| manifests (`issue #4475 <https://github.com/platformio/platformio-core/issues/4475>`_)
 
 6.1.5 (2022-11-01)
 ~~~~~~~~~~~~~~~~~~
@@ -58,7 +60,7 @@ PlatformIO Core 6
 * Export a ``PIO_UNIT_TESTING`` macro to the project source files and dependent libraries in the |UNITTESTING| mode
 * Improved detection of Windows architecture (`issue #4353 <https://github.com/platformio/platformio-core/issues/4353>`_)
 * Warn about unknown `device monitor filters <https://docs.platformio.org/en/latest/core/userguide/device/cmd_monitor.html#filters>`__ (`issue #4362 <https://github.com/platformio/platformio-core/issues/4362>`_)
-* Fixed a regression bug when `libArchive <https://docs.platformio.org/en/latest/manifests/library-json/fields/build/libarchive.html>`__ option declared in the `library.json <https://docs.platformio.org/en/latest/manifests/library-json/index.html>`__ manifest was ignored (`issue #4351 <https://github.com/platformio/platformio-core/issues/4351>`_)
+* Fixed a regression bug when `libArchive <https://docs.platformio.org/en/latest/manifests/library-json/fields/build/libarchive.html>`__ option declared in the |LIBRARYJSON| manifest was ignored (`issue #4351 <https://github.com/platformio/platformio-core/issues/4351>`_)
 * Fixed an issue when the `pio pkg publish <https://docs.platformio.org/en/latest/core/userguide/pkg/cmd_publish.html>`__ command didn't work with Python 3.6 (`issue #4352 <https://github.com/platformio/platformio-core/issues/4352>`_)
 
 6.1.1 (2022-07-11)

platformio/package/commands/list.py

@@ -84,10 +84,16 @@ def print_dependency_tree(pm, specs=None, filter_specs=None, level=0, verbose=Fa
     if not candidates:
         return
     candidates = sorted(candidates.values(), key=lambda item: item[0].metadata.name)
+
     for index, (pkg, spec) in enumerate(candidates):
         if filtered_pkgs and not _pkg_tree_contains(pm, pkg, filtered_pkgs):
             continue
-        dependencies = pm.get_pkg_dependencies(pkg)
+        printed_pkgs = pm.memcache_get("__printed_pkgs", [])
+        if printed_pkgs and pkg.path in printed_pkgs:
+            continue
+        printed_pkgs.append(pkg.path)
+        pm.memcache_set("__printed_pkgs", printed_pkgs)
+
         click.echo(
             "%s%s %s"
             % (
@@ -100,6 +106,8 @@ def print_dependency_tree(pm, specs=None, filter_specs=None, level=0, verbose=Fa
                 ),
             )
         )
+
+        dependencies = pm.get_pkg_dependencies(pkg)
         if dependencies:
             print_dependency_tree(
                 pm,

platformio/package/manager/_uninstall.py

@@ -35,6 +35,12 @@ def _uninstall(self, spec, skip_dependencies=False):
         if not pkg or not pkg.metadata:
             raise UnknownPackageError(spec)
 
+        uninstalled_pkgs = self.memcache_get("__uninstalled_pkgs", [])
+        if uninstalled_pkgs and pkg.path in uninstalled_pkgs:
+            return pkg
+        uninstalled_pkgs.append(pkg.path)
+        self.memcache_set("__uninstalled_pkgs", uninstalled_pkgs)
+
         self.log.info(
             "Removing %s @ %s"
             % (click.style(pkg.metadata.name, fg="cyan"), pkg.metadata.version)