Fix an issue when "srcFilter" field in "library.json" breaks a librar…

…y build // Resolve #1735
platformio · Jul 26, 2018 · 9191ea9 · 9191ea9
1 parent fedf316
commit 9191ea9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/HISTORY.rst b/HISTORY.rst
@@ -13,6 +13,10 @@ PlatformIO 3.0
   - Force building of project source code using `test_build_project_src <http://docs.platformio.org/page/projectconf/section_env_test.html#test_build_project_src>`__ option
   - Fixed missed ``UNIT_TEST`` macro for unit test components/libraries
 
+* Fixed an issue when ``srcFilter`` field in `library.json <http://docs.platformio.org/page/librarymanager/config.html>`__
+  breaks a library build
+  (`issue #1735 <https://github.com/platformio/platformio-core/issues/1735>`_)
+
 3.5.4 (2018-07-03)
 ~~~~~~~~~~~~~~~~~~
 

diff --git a/platformio/builder/tools/piolib.py b/platformio/builder/tools/piolib.py
@@ -586,15 +586,6 @@ def load_manifest(self):
     def _is_arduino_manifest(self):
         return isfile(join(self.path, "library.properties"))
 
-    @property
-    def src_dir(self):
-        if all([
-                "srcFilter" in self._manifest.get("build", {})
-                or self.env['SRC_FILTER'], not self._is_arduino_manifest()
-        ]):
-            return self.path
-        return LibBuilderBase.src_dir.fget(self)
-
     @property
     def src_filter(self):
         if "srcFilter" in self._manifest.get("build", {}):