Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pio run does not include/print library dependencies from common_env_data #1150

Closed
andig opened this issue Oct 30, 2017 · 6 comments
Closed
Milestone

Comments

@andig
Copy link

andig commented Oct 30, 2017

It would be great if lib_deps could be placed inside common_env_data. Currently that does not seem to be the case.

pio run (v3.5.0a16) does neither show a warning about an invalid key in common_env_data nor include the libraries.

@ivankravets
Copy link
Member

Could you provide an example with platformio.ini?

@andig
Copy link
Author

andig commented Nov 3, 2017

Looking at http://docs.platformio.org/en/latest/projectconf.html and

; You MUST inject these options into [env:] section
; using ${common_env_data.***} (see below)

I think this is the expected bevaviour.

[common_env_data]
lib_deps =
    OneWire

Is simply not expected to work?

@ivankravets ivankravets added this to the 3.5.0 milestone Nov 3, 2017
@andig andig mentioned this issue Nov 3, 2017
1 task
@andig
Copy link
Author

andig commented Nov 8, 2017

ping @ivankravets I think we can close this one unless you want to change the [common_env_data] behaviour?

@ivankravets
Copy link
Member

I don't understand this issue. Could you explain me?

@andig
Copy link
Author

andig commented Nov 9, 2017

My problem was putting lib_deps into [common_env_data] and expecting the libs to be included for multiple environments:

[common_env_data]
lib_deps=
  ESPAsyncWebServer@^1.1
  OneWire@^2.3
  DHT Sensor Library@^1.3
  DallasTemperature@^3.7

[env:esp8266]
platform=espressif8266
framework=arduino
    # no lib_deps here

[env:esp32]
platform=espressif32_stage
framework=arduino
    # no lib_deps here

But I think this is simply wrong since the libs need to be imported into every env section:

[env:esp8266]
platform=espressif8266
framework=arduino
lib_deps=
  ${common_env_data.lib_deps}

If this understanding is correct we can close, no enhancement needed, just user too stupid...

@ivankravets
Copy link
Member

Sure, you should include template in real environment block.

ivankravets added a commit that referenced this issue Dec 28, 2017
… issue #1236, issue #1235, issue #953, issue #1118, issue #1107, issue #1196, issue #1179, issue #1161, issue #1126, issue #104, issue #1033, issue #1034, issue #1175, issue #1173, issue #1155, issue #1188, issue #1111, issue #1153, issue #1150, issue #1145, issue #1139, issue #1137, issue #1170, issue #1157, issue #1102, issue #1105, issue #1140, issue #1154, issue #1066, issue #1038, issue #1054, issue #1055, issue #1061, issue #1017)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants