Make PlatformIO Python 3 compatible #895

StefanD986 · 2017-02-03T11:39:42Z

Configuration

Operating system:
Windows and Mac

PlatformIO Version (platformio --version):
PlatformIO, version 3.2.1

Description of problem

PlatformIO is not compatible to Python 3 (as stated on the website). It would be nice and would ease the install process if PlatformIO would also work with Python 3.

The text was updated successfully, but these errors were encountered:

ivankravets · 2017-02-03T11:50:22Z

PlatformIO's Build System depends on SCons tool that doesn't support Python 3. Please note that SCons team works in this way.

skorokithakis · 2017-08-05T14:50:34Z

@ivankravets How hard would it be to remove this dependency, or replace it with something else?

Would it be feasible to write an adapter module that called out to SCons from Python 3? Although that would be a hassle when installing...

Python 2 is quickly becoming irrelevant, and I'm finding myself having to keep a Python 2 env around just for PlatformIO. I think this should be a higher priority, as PlatformIO risks finding itself in a position where it can't be easily installed soon (with OSes moving to Py3).

I would be willing to contribute some code to the migration to Py3.

ivankravets · 2017-08-05T14:56:19Z

PlatformIO risks finding itself in a position where it can't be easily installed soon (with OSes moving to Py3).

Python 2 is a stable and supported branch. I think, minimum 5 years all major OSs will include Python 2 distribution by default (as they now do). Hundred OS-dependent libraries and software are written in Python 2: macOS, Linux, BSD.

Nevertheless, SCons Team hardly working on the first Python3 compatible release.

https://bitbucket.org/scons/scons/src/9ef88cce4c52e65083beba3f416d45a494855693/src/CHANGES.txt?at=default&fileviewer=file-view-default

tehnorm · 2017-09-28T23:45:21Z

Just noticed that it looks like SCons 3.0.0 just released support for python 3.5+!

http://scons.org/scons-300-is-available.html

ivankravets · 2018-01-26T18:06:44Z

Upgraded to SCons 3.0 in PlatformIo Core 3.5.2 ( 59337c7 ). Now, need to upgrade PIO Core to Python 3.

… Issue #895

Add Python 3 support (backwards compatible with Python 2.7). See platformio#895. Note: platforms/packages containing Python code, e.g., [`platform-atmelavr`][1], still need to be updated to support Python 3. The [`python-modernize`][2] can help with this considerably, e.g.: python-modernize . -w will automatically use the [`six`][3] module to apply numerous transformations required for Python 2/3 compatability. The [`python-modernize`][2] tool was used for most Python 3 updates to `platformio-core` introduced by this merge, with the notable exception of unicode string handling, which required manual intervention (see below). Unicode issues -------------- In Python 3, **all** string literals (i.e., `str` objects) are **unicode** - **there is NO `unicode` type** in Python 3. In Python 3, the **`bytes` type** is equivalent to **`str` in Python 2**. Note that in Python 2 the `bytes` type may be used interchangeably with the `str` type. However, in Python 3 many library functions, e.g., `hashlib.md5.update` require `bytes` objects; **NOT `str` objects**. Thus, to work properly with Python 3, code ported from Python 2 must be updated to **explicitly decode** `str` unicode string objects to `bytes`, e.g., `my_string.encode('utf8')`. Furthermore, some Python 3 library functions now **return** `bytes` objects, e.g., `Popen.communicate`. Python 2 code interpreting the output of such functions as `str` string objects **MUST** be updated to explicitly encode the output to unicode strings to work properly in Python 3, e.g.: ```python process = subprocess.Popen(...) stdout, stderr = process.communicate() print(stdout.decode('utf8')) ``` [1]: https://github.com/platformio/platform-atmelavr.git [2]: https://github.com/python-modernize/python-modernize [3]: https://pythonhosted.org/six/

Platformio does not run on Python 3 yet. Tracking issue: platformio/platformio-core#895

mintisan · 2018-04-29T07:59:56Z

How can I install the specific version for Python3?

It seems to be not OK, if I use pip3 install platformio.

➜  ~ pip3 install platformio
Collecting platformio
  Downloading https://files.pythonhosted.org/packages/7c/95/899efc1264c63d1ba1d32b4160b2fe3d48020de00f7b8c91dc5b712aa05f/platformio-3.5.2.tar.gz (95kB)
    100% |████████████████████████████████| 102kB 238kB/s
    Complete output from command python setup.py egg_info:
    PlatformIO Core v3.5.2 does not run under Python version 3.5.1 (default, Jul  9 2016, 11:42:58)
    [GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)].
    Minimum supported version is 2.7, please upgrade Python.
    Python 3 is not yet supported.

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/7z/j_bymh4x3l7cp_m_xgk132mr0000gn/T/pip-install-dnnmbov9/platformio/

Peque · 2018-04-30T15:18:01Z

@mintisan As you can see in your pip3 command output: "Python 3 is not yet supported".

That means Platformio is currently not Python 3 compatible. Hence this issue. 😉

You may want to try pip2 install platformio (within a system/virtual environment that uses Python 2 instead).

Cabalist · 2018-05-04T17:20:46Z

There is a pull request open for this and I would be happy to help get polish it up if someone could share what is blocking it at the moment. :)

ivankravets · 2018-12-26T18:58:10Z

Hi all,

Sorry for the delay. We have finally added full support for Python 3.5+. Of course, Python 2.7 is also in the supported list.

We would be thankful if you re-test with $ pio upgrade --dev. It should be PlatformIO 4.0.

Does it work for you?

13rac1 · 2018-12-26T21:18:42Z

Awesome! Confirming install/run in Ubuntu 18.04 LTS! 🎉 👍 An existing platform.io project builds without issue. All tests, except one pass!

$ python --version
Python 3.6.7
$ python3 -m venv venv # snip
$ source venv/bin/activate # snip
$ git clone https://github.com/platformio/platformio-core --recursive
$ cd platformio-core
$ python setup.py install # snip
$ platformio --version
PlatformIO, version 4.0.0a1
$ pip install pytest # snip
# Run the test command listed in tox.ini
$ py.test -v --basetemp="/tmp/piotest" tests --ignore tests/test_examples.py # Almost Pass!
tests/commands/test_test.py::test_local_env FAILED
____________________________________________________ test_local_env ____________________________________________________

    def test_local_env():
        result = util.exec_command([
            "platformio", "test", "-d",
            join("examples", "unit-testing", "calculator"), "-e", "native"
        ])
        if result['returncode'] != 1:
            pytest.fail(result)
>       assert all([s in result['out']
                    for s in ("PASSED", "IGNORED", "FAILED")]), result['out']
E       AssertionError: Details: http://docs.platformio.org/page/userguide/account/index.html
E         
E       assert False
E        +  where False = all([False, False, False])

tests/commands/test_test.py:29: AssertionError
$ pio test -d examples/unit-testing/calculator -e native
You are not logged in. Please log in to PIO Account using PlatformIO IDE > PIO Home > Account or `pio account login` command and try again. 

If you don't have PIO Account yet, please create it using PlatformIO IDE > PIO Home > Account or `pio account register` command.
Details: http://docs.platformio.org/page/userguide/account/index.html

I have to log in? Ok.

$ pio account register # snip
$ pio account login # snip
$ pio test -d examples/unit-testing/calculator -e native
Verbose mode can be enabled via `-v, --verbose` option
Collected 3 items

========================================= [test/test_common] Building... (1/2) =========================================
Please wait...

========================================= [test/test_common] Testing... (2/2) =========================================
test/test_common/test_calculator.cpp:48:test_function_calculator_addition	[PASSED]
test/test_common/test_calculator.cpp:49:test_function_calculator_subtraction	[PASSED]
test/test_common/test_calculator.cpp:50:test_function_calculator_multiplication	[PASSED]
test/test_common/test_calculator.cpp:51:test_function_calculator_division	[PASSED]

-----------------------
4 Tests 0 Failures 0 Ignored
OK

======================================== [test/test_desktop] Building... (1/2) ========================================
Please wait...

========================================= [test/test_desktop] Testing... (2/2) =========================================
test/test_desktop/test_calculator.cpp:48:test_function_calculator_addition	[PASSED]
test/test_desktop/test_calculator.cpp:49:test_function_calculator_subtraction	[PASSED]
test/test_desktop/test_calculator.cpp:50:test_function_calculator_multiplication	[PASSED]
test/test_desktop/test_calculator.cpp:43:test_function_calculator_division:FAIL: Expected 32 Was 33	[FAILED]

-----------------------
4 Tests 1 Failures 0 Ignored
FAIL

==================================================== [TEST SUMMARY] ====================================================
test/test_common/env:uno	[IGNORED]
test/test_common/env:nodemcu	[IGNORED]
test/test_common/env:native	[PASSED]
test/test_desktop/env:uno	[IGNORED]
test/test_desktop/env:nodemcu	[IGNORED]
test/test_desktop/env:native	[FAILED]
test/test_embedded/env:uno	[IGNORED]
test/test_embedded/env:nodemcu	[IGNORED]
test/test_embedded/env:native	[IGNORED]
============================================== [FAILED] Took 0.71 seconds ==============================================

Edit Again: it fails if I run this test with pio, but passes if I run it, while logged in, with pytest. Seems odd.

tests/commands/test_test.py::test_local_env PASSED                                                               [ 98%]

rab852 · 2018-12-29T22:52:42Z

Using a windows machine I can download the dev branch but still has the python 2.7.13 dependency

ivankravets · 2019-01-01T22:08:06Z

@rab852 PlatformIO IDE currently depends on Python 2.7. Please open an issue here https://github.com/platformio/platformio-vscode-ide/issues

AlexFBP · 2019-02-09T00:32:27Z

Just saying...

$ pip install -U platformio
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020.
Please upgrade your Python as Python 2.7 won't be maintained after that date.
A future version of pip will drop support for Python 2.7.

ivankravets · 2019-02-09T16:22:36Z

You can use PlatformIO Core 4.0 which supports Python 3. See https://docs.platformio.org/en/latest/installation.html#development-version

Navis-Raven · 2019-02-15T10:45:33Z

@ivankravets When PlatformeIO Core 4.0 will be released ?

ivankravets · 2019-02-15T12:25:29Z

See https://github.com/platformio/platformio-core/milestone/57

ivankravets added the feature label Feb 3, 2017

ivankravets added this to the 3.5.0 milestone Sep 18, 2017

ivankravets removed this from the 3.5.0 milestone Oct 31, 2017

ivankravets mentioned this issue Dec 22, 2017

Python 3.x support #1253

Closed

ivankravets added a commit that referenced this issue Jan 26, 2018

Upgrad build system to SCons 3.0 // Issue #895

59337c7

ivankravets mentioned this issue Jan 27, 2018

H801: Seperate ON/OFF for all Channels "RELAY_PROVIDER_LIGHT" xoseperez/espurna#457

Closed

ivankravets added a commit that referenced this issue Jan 30, 2018

Revert back to SCons 2.0, a lot of issues with non-unicode locales //…

fc53cb4

… Issue #895

cfobel mentioned this issue Feb 13, 2018

Python 3.x support #595

Closed

cfobel mentioned this issue Feb 14, 2018

feat(py3): add Python 3 support (backwards compatible with Python 2.7) #1365

Closed

dbrgn added a commit to gfroerli/firmware that referenced this issue Mar 30, 2018

Require Python 2.7 in Pipfile

96ca26b

Platformio does not run on Python 3 yet. Tracking issue: platformio/platformio-core#895

dbrgn mentioned this issue Mar 30, 2018

Require Python 2.7 in Pipfile gfroerli/firmware#21

Merged

dbrgn added a commit to gfroerli/firmware that referenced this issue Mar 31, 2018

Require Python 2.7 in Pipfile (#21)

0300ada

Platformio does not run on Python 3 yet. Tracking issue: platformio/platformio-core#895

ivankravets mentioned this issue May 22, 2018

Python 3.6 and PIO platformio/platformio-vscode-ide#108

Closed

ivankravets modified the milestones: Backlog, 4.0 Aug 6, 2018

ivankravets mentioned this issue Aug 28, 2018

InstallationManager platformio/platformio-atom-ide#2056

Closed

ivankravets added a commit that referenced this issue Oct 27, 2018

Use "super" when calling parent class // Issue #895

5c278b5

ivankravets added a commit that referenced this issue Oct 27, 2018

Use "items" instead of "iteritems" (PY2/3) // Issue #895

e94d758

ivankravets added a commit that referenced this issue Oct 27, 2018

Initial support for Python 3.5+ // Resolve #895

527f632

ivankravets closed this as completed in a60c57a Dec 26, 2018

OttoWinter mentioned this issue Dec 30, 2018

Make compatible with python 3 esphome/esphome#281

Merged

2 tasks

Andrei-Pozolotin mentioned this issue Apr 24, 2019

[BUG] python 2 -> 3 script migration MarlinFirmware/Marlin#13801

Closed

ivankravets mentioned this issue Jul 10, 2019

platformio 4.0.0 Homebrew/homebrew-core#41821

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make PlatformIO Python 3 compatible #895

Make PlatformIO Python 3 compatible #895

StefanD986 commented Feb 3, 2017 •

edited by ivankravets

Loading

ivankravets commented Feb 3, 2017

skorokithakis commented Aug 5, 2017

ivankravets commented Aug 5, 2017

tehnorm commented Sep 28, 2017

ivankravets commented Jan 26, 2018 •

edited

Loading

mintisan commented Apr 29, 2018

Peque commented Apr 30, 2018

Cabalist commented May 4, 2018

ivankravets commented Dec 26, 2018

13rac1 commented Dec 26, 2018 •

edited

Loading

rab852 commented Dec 29, 2018

ivankravets commented Jan 1, 2019

AlexFBP commented Feb 9, 2019

ivankravets commented Feb 9, 2019

Navis-Raven commented Feb 15, 2019

ivankravets commented Feb 15, 2019

Make PlatformIO Python 3 compatible #895

Make PlatformIO Python 3 compatible #895

Comments

StefanD986 commented Feb 3, 2017 • edited by ivankravets Loading

Configuration

Description of problem

ivankravets commented Feb 3, 2017

skorokithakis commented Aug 5, 2017

ivankravets commented Aug 5, 2017

tehnorm commented Sep 28, 2017

ivankravets commented Jan 26, 2018 • edited Loading

mintisan commented Apr 29, 2018

Peque commented Apr 30, 2018

Cabalist commented May 4, 2018

ivankravets commented Dec 26, 2018

13rac1 commented Dec 26, 2018 • edited Loading

rab852 commented Dec 29, 2018

ivankravets commented Jan 1, 2019

AlexFBP commented Feb 9, 2019

ivankravets commented Feb 9, 2019

Navis-Raven commented Feb 15, 2019

ivankravets commented Feb 15, 2019

StefanD986 commented Feb 3, 2017 •

edited by ivankravets

Loading

ivankravets commented Jan 26, 2018 •

edited

Loading

13rac1 commented Dec 26, 2018 •

edited

Loading