Fix: Check for arrow functions in no-loose-assertions & no-assert-ok

Both of these rules use utils.createAssertionCheck, which only checks for non-arrow functions. Fixes #213
platinumazure · Nov 2, 2021 · 4ddda0d · 4ddda0d
1 parent 34968fe
commit 4ddda0d
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/lib/utils.js b/lib/utils.js
@@ -218,7 +218,7 @@ exports.isSkip = function (calleeNode) {
 
 exports.getAssertContextNameForTest = function (argumentsNodes) {
     const functionExpr = argumentsNodes.find(function (argNode) {
-        return argNode.type === "FunctionExpression";
+        return argNode.type === "FunctionExpression" || argNode.type === "ArrowFunctionExpression";
     });
 
     return this.getAssertContextName(functionExpr);

diff --git a/tests/lib/rules/no-assert-ok.js b/tests/lib/rules/no-assert-ok.js
@@ -47,6 +47,17 @@ ruleTester.run("no-assert-ok", rule, {
                 }
             }]
         },
+        {
+            code: "QUnit.test('Name', (assert) => { assert.ok(a); });",
+            parserOptions: { ecmaVersion: 6 },
+            errors: [{
+                messageId: "unexpectedLocalOkNotOk",
+                data: {
+                    assertVar: "assert",
+                    assertion: "ok"
+                }
+            }]
+        },
         {
             code: "QUnit.test('Name', function (foo) { foo.ok(a); });",
             errors: [{

diff --git a/tests/lib/rules/no-loose-assertions.js b/tests/lib/rules/no-loose-assertions.js
@@ -47,6 +47,17 @@ ruleTester.run("no-loose-assertions", rule, {
                 }
             }]
         },
+        {
+            code: "QUnit.test('Name', (assert) => { assert.ok(a); });",
+            parserOptions: { ecmaVersion: 6 },
+            errors: [{
+                messageId: "unexpectedLocalLooseAssertion",
+                data: {
+                    assertVar: "assert",
+                    assertion: "ok"
+                }
+            }]
+        },
         {
             code: "QUnit.test('Name', function (foo) { foo.ok(a); });",
             errors: [{