Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fixToNotOk option from no-compare-relation-boolean and no-negated-ok rules #195

Closed
bmish opened this issue Jun 29, 2021 · 1 comment · Fixed by #197
Closed

Remove fixToNotOk option from no-compare-relation-boolean and no-negated-ok rules #195

bmish opened this issue Jun 29, 2021 · 1 comment · Fixed by #197
Labels
accepted breaking rule enhancement

Comments

@bmish
Copy link
Collaborator

bmish commented Jun 29, 2021

These options were only intended for backwards compatibility. We could remove them to simplify the rules and ease the maintenance burden.

notOk was added in QUnit 1.18, any we don't need to support older versions anymore.

Breaking change that could be part of the v7 release (#175).
@bmish bmish mentioned this issue Jun 29, 2021
Closed
@platinumazure
Copy link
Owner

@bmish Sounds good to me. I've added this to the project. Thanks for the suggestion!

@bmish bmish mentioned this issue Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted breaking rule enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Breaking: Remove fixToNotOk and checkBooleanAssertions rule options bmish/eslint-plugin-qunit
2 participants
@platinumazure @bmish