Breaking: Remove fixToNotOk and checkBooleanAssertions rule options
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The [notOk](https://api.qunitjs.com/assert/notOk/) assertion was added in QUnit 1.18, and we only support QUnit 2+, so we can enable/remove the `fixToNotOk` option so that rules can assume `notOk` is available * The [true](https://api.qunitjs.com/assert/true/) and [false](https://api.qunitjs.com/assert/false/) boolean assertions were added in QUnit 2.11, and enabling/removing the `checkBooleanAssertions` option will subject these assertions to additional linting
bmish
force-pushed
the
remove-fixToNotOk-checkBooleanAssertions-options
branch
from
6f3cfd8
to
2f9ed80
Compare
Krinkle
approved these changes
Jul 24, 2021
platinumazure
approved these changes
Aug 25, 2021
This was referenced Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixToNotOkoption so that rules can assumenotOkis availablecheckBooleanAssertionsoption will subject these assertions to additional lintingWe can remove these options to simplify the rules and ease the maintenance burden.
Removed these options together to avoid conflicts since a lot of the code overlaps.
Fixes #190, fixes #195. Part of the v7 release (#175).