Breaking: Enable checkBooleanAssertions in no-negated-ok and no-ok-equality by default

docs/rules/no-negated-ok.md

@@ -54,7 +54,7 @@ QUnit.test('test', function (assert) {
 
 This rule takes an optional object containing:
 
-* `checkBooleanAssertions` (boolean, default: false): Whether the rule should check the [true](https://api.qunitjs.com/assert/true/) and [false](https://api.qunitjs.com/assert/false/) boolean assertions
+* `checkBooleanAssertions` (boolean, default: true): Whether the rule should check the [true](https://api.qunitjs.com/assert/true/) and [false](https://api.qunitjs.com/assert/false/) boolean assertions
 * `fixToNotOk` (boolean, default: true): Whether the rule should autofix `assert.ok(!foo)` to `assert.notOk(foo)` ([notOk](https://api.qunitjs.com/assert/notOk/) was added in QUnit 1.18)
 
 ## When Not to Use It

docs/rules/no-ok-equality.md

@@ -67,7 +67,7 @@ QUnit.test("Name", function (assert) { assert.ok(x instanceof Number); });
 This rule takes an optional object containing:
 
 * `allowGlobals` (boolean, default: true): Whether the rule should check global assertions
-* `checkBooleanAssertions` (boolean, default: false): Whether the rule should check the [true](https://api.qunitjs.com/assert/true/) and [false](https://api.qunitjs.com/assert/false/) boolean assertions
+* `checkBooleanAssertions` (boolean, default: true): Whether the rule should check the [true](https://api.qunitjs.com/assert/true/) and [false](https://api.qunitjs.com/assert/false/) boolean assertions
 
 ## When Not to Use It
 

lib/rules/no-negated-ok.js

@@ -36,7 +36,7 @@ module.exports = {
                 properties: {
                     checkBooleanAssertions: {
                         type: "boolean",
-                        default: false
+                        default: true
                     },
                     fixToNotOk: {
                         type: "boolean",
@@ -49,7 +49,7 @@ module.exports = {
     },
 
     create: function (context) {
-        const checkBooleanAssertions = context.options[0] && context.options[0].checkBooleanAssertions;
+        const checkBooleanAssertions = !context.options[0] || context.options[0].checkBooleanAssertions;
         const fixToNotOk = !context.options[0] || context.options[0].fixToNotOk;
 
         const POSITIVE_ASSERTIONS = checkBooleanAssertions ? ["ok", "true"] : ["ok"];

lib/rules/no-ok-equality.js

@@ -44,7 +44,7 @@ module.exports = {
         const asyncStateStack = [],
             DEFAULT_OPTIONS = {
                 allowGlobal: true,
-                checkBooleanAssertions: false
+                checkBooleanAssertions: true
             },
             options = context.options[0] || DEFAULT_OPTIONS,
             sourceCode = context.getSourceCode();

tests/lib/rules/no-negated-ok.js

@@ -111,12 +111,6 @@ ruleTester.run("no-negated-ok", rule, {
             options: [{ checkBooleanAssertions: true }]
         },
 
-        // Boolean assertions, negation, checkBooleanAssertions = false (implicitly)
-        wrap("assert.true(!foo)"),
-        wrap("assert.true(!foo, 'message')"),
-        wrap("assert.false(!foo)"),
-        wrap("assert.false(!foo, 'message')"),
-
         // Boolean assertions, negation, checkBooleanAssertions = false (explicitly)
         {
             code: wrap("assert.true(!foo)"),
@@ -237,6 +231,11 @@ ruleTester.run("no-negated-ok", rule, {
         },
 
         // true
+        {
+            code: wrap("assert.true(!foo)"),
+            output: wrap("assert.false(foo)"),
+            errors: [createError("assert.true")]
+        },
         {
             code: wrap("assert.true(!foo)"),
             output: wrap("assert.false(foo)"),
@@ -245,6 +244,11 @@ ruleTester.run("no-negated-ok", rule, {
         },
 
         // false
+        {
+            code: wrap("assert.false(!foo)"),
+            output: wrap("assert.true(foo)"),
+            errors: [createError("assert.false")]
+        },
         {
             code: wrap("assert.false(!foo)"),
             output: wrap("assert.true(foo)"),

tests/lib/rules/no-ok-equality.js

@@ -99,10 +99,6 @@ ruleTester.run("no-ok-equality", rule, {
             options: [{ checkBooleanAssertions: true }]
         },
 
-        // Boolean assertions with equality checks (checkBooleanAssertions = false, implicitly)
-        "test('Name', function (assert) { assert.true(x === 1); });",
-        "test('Name', function (assert) { assert.false(x === 1); });",
-
         // Boolean assertions with equality checks (checkBooleanAssertions = false, explicitly)
         {
             code: "test('Name', function (assert) { assert.true(x === 1); });",
@@ -244,6 +240,22 @@ ruleTester.run("no-ok-equality", rule, {
             ]
         },
 
+        // Boolean assertions with equality checks (checkBooleanAssertions = true, implicitly)
+        {
+            code: "test('Name', function (assert) { assert.true(x === 1); });",
+            output: "test('Name', function (assert) { assert.strictEqual(x, 1); });",
+            errors: [
+                createError("assert.true", "assert.strictEqual", "x", "1")
+            ]
+        },
+        {
+            code: "test('Name', function (assert) { assert.false(x === 1); });",
+            output: "test('Name', function (assert) { assert.notStrictEqual(x, 1); });",
+            errors: [
+                createError("assert.false", "assert.notStrictEqual", "x", "1")
+            ]
+        },
+
         // Boolean assertions with equality checks (checkBooleanAssertions = true, explicitly)
         {
             // true