Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rule docs mention all rule options #212

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Oct 30, 2021

Add test to ensure:

  1. Any rule with options has a ## Options section in its rule doc.
  2. Any named rule options are mentioned in the rule doc.

Based on the same test I wrote here: https://github.com/ember-cli/eslint-plugin-ember/blob/4f26c0bc7e34400007e02939a9c6e183078a3e87/tests/rule-setup.js#L111

@coveralls
Copy link

coveralls commented Oct 30, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling d8c4642 on bmish:rule-setup-test-options into 5f50d24 on platinumazure:master.

Copy link
Owner

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is huge, thanks for this!

@platinumazure platinumazure merged commit 34968fe into platinumazure:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants