Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases of pure text addition (except for adding a line to the end of the file) #56

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

oleg-derevenetz
Copy link
Contributor

To handle replacements like this:

oleg-derevenetz/fheroes2#165 (review)

In this replacement initialization of _displayMonitor is moved before initialization of _nearestScaling like this:

+             , _displayMonitor( 0 )
              , _nearestScaling( false )
-             , _displayMonitor( 0 )

so it's a pure addition followed by pure removal.

The corresponding run URL is:

https://github.com/oleg-derevenetz/fheroes2/actions/runs/6972839758/job/18975746167#step:8:1

Copy link
Owner

@platisd platisd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, should we consider this version-wise as a fix?

@platisd platisd merged commit 121c8f8 into platisd:master Nov 24, 2023
2 checks passed
@oleg-derevenetz oleg-derevenetz deleted the handle-only-additions branch November 24, 2023 14:29
@oleg-derevenetz
Copy link
Contributor Author

Seems reasonable, should we consider this version-wise as a fix?

Why not. Especially given that Docker image has been updated recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants