refactor to composite action

[renefritze]

No description provided.

[platisd]

Good work. Do you have a link to a successful run?

Also, from what I understand, the users don't need to change anything when they use the Action. It will run in whatever environment they have launched, correct?

[renefritze]

Good work. Do you have a link to a successful run?

Thanks. I've only tested it on a private project. I'll have a think on how this could be generally tested in CI here.

Also, from what I understand, the users don't need to change anything when they use the Action. It will run in whatever environment they have launched, correct?

Generally, yeah. If they are already setting up python, they'd need to pass in their version, else the setup-action will clash.

[oleg-derevenetz]

Hi @renefritze what if GITHUB_ACTION_PATH contains a space or a special character like ? or * - here and in the action.yml?

[platisd]

Has this been addressed @renefritze btw?

[renefritze]

Quoted the paths, yes.

[platisd]

Generally, yeah. If they are already setting up python, they'd need to pass in their version, else the setup-action will clash.

@renefritze 🤔 can we do anything to avoid a new major version, since this is a breaking change?

[platisd]

Generally, yeah. If they are already setting up python, they'd need to pass in their version, else the setup-action will clash.

@renefritze 🤔 can we do anything to avoid a new major version, since this is a breaking change?

Some follow-up questions I just thought:

• What are the consequences of such "clash"? That after running this action the user will end up with a potentially different Python version than the one they had set up?
• If there's no way to avoid this clash, what's the best way to make it very clear to the users this may happen and therefore they need to explicitly set the python version?
  • Potentially make the Python version of this action a required argument?

[renefritze]

Some follow-up questions I just thought:

• What are the consequences of such "clash"? That after running this action the user will end up with a potentially different Python version than the one they had set up?

I don't know. From the docs on setting multiple versions, I would think the last version "wins", yeah.

• Potentially make the Python version of this action a required argument?

That would work, yes.
I might just have had a better idea that isolates this action's setup entirely: 51a21cb

[platisd]

Some follow-up questions I just thought:

• What are the consequences of such "clash"? That after running this action the user will end up with a potentially different Python version than the one they had set up?

I don't know. From the docs on setting multiple versions, I would think the last version "wins", yeah.

• Potentially make the Python version of this action a required argument?

That would work, yes. I might just have had a better idea that isolates this action's setup entirely: 51a21cb

${GITHUB_ACTION_PATH}/venv/python -m pip install -r ${GITHUB_ACTION_PATH}/requirements.txt

Did this work?

[platisd]

Also, can you please rebase so this sits on top of #63 and therefore we get the new workflow triggered?

[renefritze]

Some follow-up questions I just thought:

• What are the consequences of such "clash"? That after running this action the user will end up with a potentially different Python version than the one they had set up?

I don't know. From the docs on setting multiple versions, I would think the last version "wins", yeah.

• Potentially make the Python version of this action a required argument?

That would work, yes. I might just have had a better idea that isolates this action's setup entirely: 51a21cb

${GITHUB_ACTION_PATH}/venv/python -m pip install -r ${GITHUB_ACTION_PATH}/requirements.txt

Did this work?

Not right away :)
https://github.com/platisd/clang-tidy-pr-comments/actions/runs/7531944101/job/20501597277?pr=62

[renefritze]

Noticed I still had a !fixup commit in here, squashed that and force pushed.

[platisd]

Sorry for the force pushing. Tested out the PR here.

[platisd]

OK, I squashed some commits to make it more clear what is being done in this PR, hope that's fine with your @renefritze

[renefritze]

OK, I squashed some commits to make it more clear what is being done in this PR, hope that's fine with your @renefritze

Sure thing.

[platisd]

Thanks for your efforts, it's now included in the latest release! 🎉

[renefritze]

Awesome, thank you very much for working with me.