Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the extra backslash #77

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

oleg-derevenetz
Copy link
Contributor

No description provided.

@renefritze
Copy link
Contributor

How about adding https://github.com/koalaman/shellcheck-precommit to the config to catch this type of thing automatically in the future?

@oleg-derevenetz
Copy link
Contributor Author

How about adding https://github.com/koalaman/shellcheck-precommit to the config to catch this type of thing automatically in the future?

I don't use the pre-commit tool. If you use it, you are welcome to do this.

@oleg-derevenetz
Copy link
Contributor Author

BTW shellcheck is not able to catch this extra backslash yet (if the last line of the script ends with a line break). But let it be.

@platisd platisd merged commit 809cc8a into platisd:master Mar 26, 2024
4 checks passed
@platisd
Copy link
Owner

platisd commented Mar 26, 2024

How about adding https://github.com/koalaman/shellcheck-precommit to the config to catch this type of thing automatically in the future?

Not a big fan of them myself either, prefer a CI check instead. :P

@renefritze
Copy link
Contributor

How about adding https://github.com/koalaman/shellcheck-precommit to the config to catch this type of thing automatically in the future?

Not a big fan of them myself either, prefer a CI check instead. :P

IMO it's best to combine both. One of my workflows always does pre-commit run -a to ensure the PR is actually following formatting, etc encoded through tools in the pre-commit setup.

@oleg-derevenetz oleg-derevenetz deleted the copy-paste-fix branch March 26, 2024 09:15
@platisd
Copy link
Owner

platisd commented Mar 26, 2024

Btw, I am also open to introducing this as a pre-commit too. :}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants