-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually lock outgrown enterprise accounts #2197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
vinibrsl
force-pushed
the
enterprise-plan-usage-emails
branch
5 times, most recently
from
September 13, 2022 15:55
1829a12
to
3be6fd0
Compare
vinibrsl
changed the title
Send alert e-mails to outgrown enterprise accounts
Manually lock outgrown enterprise accounts
Sep 13, 2022
vinibrsl
force-pushed
the
enterprise-plan-usage-emails
branch
3 times, most recently
from
September 15, 2022 12:23
c7274b9
to
e9b59f9
Compare
vinibrsl
force-pushed
the
enterprise-plan-usage-emails
branch
from
September 16, 2022 00:22
e9b59f9
to
3e602db
Compare
ukutaht
reviewed
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall 👍 Some comments inline
vinibrsl
force-pushed
the
enterprise-plan-usage-emails
branch
from
September 16, 2022 22:04
3e602db
to
2adff44
Compare
vinibrsl
force-pushed
the
enterprise-plan-usage-emails
branch
from
September 16, 2022 22:21
2adff44
to
17f1511
Compare
vinibrsl
force-pushed
the
enterprise-plan-usage-emails
branch
from
September 19, 2022 20:17
c5e13c8
to
7e400da
Compare
ukutaht
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request adapts the account locking and grace period flow to enterprise customers. A quick summary of the changes:
Workers.CheckUsage
, therefore showing existing dashboard alertsmanual_lock
field in thegrace_period
JSON, that whentrue
, does not expire the grace period automatically, therefore preventingWorkers.LockSites
to lock enterprise customersI recorded this screencast previewing the feature. There's been some refactoring, so small commits can help reviewing.
Tests
Changelog
Documentation
Dark mode