-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shared link with bad auth #2225
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Especially the refactoring :)
9210788
to
292bfeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
@@ -115,7 +115,7 @@ defmodule Plausible.MixProject do | |||
{:telemetry, "~> 1.0", override: true}, | |||
{:timex, "~> 3.7"}, | |||
{:ua_inspector, "~> 3.0"}, | |||
{:ex_doc, "~> 0.28"} | |||
{:ex_doc, "~> 0.28", only: :dev, runtime: false} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
e9ee194
to
fa7799d
Compare
Changes
This work started as a bug fix for a Sentry error. I used the opportunity for some refactoring & docs as well.
Plausible.StatsController.shared_link/2
for clarityDuring development I found that backwards compatibility for the older format of shared links was broken in this commit.
Tests
Changelog
Documentation
Dark mode